Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guessTheNumber and getParentchainsInfo to the integritee worker #113

Merged
merged 16 commits into from
Oct 11, 2024

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Oct 9, 2024

This turned out to be a little more involved, as the code from before was a bit too opinionated towards the public/trusted getters structure. All in all it was straightforward though.

@clangenb clangenb mentioned this pull request Oct 9, 2024
@clangenb clangenb marked this pull request as draft October 9, 2024 14:34
@brenzi
Copy link
Member

brenzi commented Oct 10, 2024

moving target. I have nested the guess-the-number calls and getters here (to become v0.14.2):
integritee-network/worker#1611

I suggest to do the new ParentchainInfo getter at the same time

I'd like to insist on custom indexes because it simplifies reverse-compatibility

@clangenb clangenb marked this pull request as ready for review October 11, 2024 12:26
@clangenb clangenb changed the title Add guess the number interface for the integritee worker Add guessTheNumber and getParentchainsInfo to the integritee worker Oct 11, 2024
@clangenb clangenb merged commit b91e972 into master Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants