-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to polkadot v1.0.0 #339
Conversation
annoying: seems we lose the std feature somewhere along the way, but all tomls checked |
Serde error is fixed by updating to the newest encointer-pallet's commit, but the build is now stuck in the client because the api-client is still on v0.9.42: scs/substrate-api-client#625 |
seems like srtool needs an upgrade to a newer rustc |
.github/workflows/ci.yml
Outdated
@@ -122,7 +122,7 @@ jobs: | |||
image: paritytech/srtool | |||
chain: ${{ matrix.runtime }} | |||
# Can remove that when we can build with stable, see: https://github.com/integritee-network/parachain/issues/200 | |||
tag: 1.66.1 | |||
tag: 1.71.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here for the following reason: By default the newest srtool image is taken. However all images after 1.66.1 only have the stable toolchain installed, which fails as long as we have the nightly in our rust-toolchain.toml
.
It was substrate that prevented the change to a stable rust-toolchain if I remember correctly, so we can just try switching the toolchain to some stable version, and maybe it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does. thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, the number of changes was turned out to be not so big after all. :)
Approving, and you can merge once you mage the CI pass. Exchanging nightly-
with stable-
in the rust-toolchain.toml
should fix the issue.
@@ -1,4 +1,4 @@ | |||
[toolchain] | |||
channel = "nightly-2023-01-13" | |||
channel = "nightly-2023-05-22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually surprised that it works. Earlier srtool images returned an error because it only has the stable toolchain installed, which conflicted with the one here. Don't know what changed on their end.
integrates encointer/pallets#332
CI