polkadot-stable2024012-2 #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
commented
Feb 25, 2025
Comment on lines
+17
to
+21
| pub type EncointerXt<Call> = UncheckedExtrinsic< | ||
| ExtrinsicAddress, | ||
| Call, | ||
| Signature, | ||
| GenericSignedExtra<CommunityCurrencyTip, Nonce>, | ||
| GenericTxExtension<CommunityCurrencyTip, Nonce>, |
There was a problem hiding this comment.
With this update, we implicitly introduce the UncheckedExtrinsicV5. However, it is entirely backwards compatible, and should not introduce any errors. (The parachain will support the V5 too with the stable2412 update).
clangenb
commented
Feb 25, 2025
|
|
||
| - name: Summary |
There was a problem hiding this comment.
Did this while debugging the srtool-build. It turns out that a downgrade is all that was needed XD.
Regardless, we could simplify here a bit as subwasm is included in srtool.
clangenb
commented
Feb 25, 2025
| RUN apt update && apt install -yq jq netcat | ||
| RUN apt update && apt install -yq jq netcat ca-certificates |
There was a problem hiding this comment.
Luckily, we test docker in CI too. After the upgrade, the node was complaining about missing root CAs in the docker.
clangenb
commented
Feb 25, 2025
| @@ -61,7 +61,6 @@ sp-offchain = { workspace = true } | |||
| sp-runtime = { workspace = true } | |||
| sp-session = { workspace = true } | |||
| sp-staking = { workspace = true } | |||
| sp-std = { workspace = true } | |||
There was a problem hiding this comment.
substrate is deprecating sp-std and started to migrate to core and alloc instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
()weights other use weights that we created in 2022. Shall we just completely switch to using()? Or we fix the benchmarks, which might be a 1 hour task, see How to handle the weights and benchmarks (re-generate or switch to substrate defaults)? #397.