Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ep-core] introduce Bip340 struct #350

Merged
merged 11 commits into from
Sep 15, 2023
Merged

[ep-core] introduce Bip340 struct #350

merged 11 commits into from
Sep 15, 2023

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Sep 15, 2023

Introduce proper struct, so that we can simplify deserialization of the Bip340 type. Otherwise, we would have had to add a [u8; 32] byte array into the spec file.

Edit: Tested that it works with the node.

Copy link
Member

@brenzi brenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if our repo here ist the right place for this. but I don't mind hosting it for now.....

@clangenb clangenb merged commit 94cbcca into master Sep 15, 2023
6 checks passed
@clangenb clangenb deleted the cl/introduce-bip340-type branch September 15, 2023 14:11
clangenb added a commit that referenced this pull request Sep 15, 2023
* [ep-core] introduce Bip340 struct

* fix unused imports

* fix no-std

* fix no-std 2

* fix no-std 3

* fix no-std 4

* fix no-std 5

* fix no-std in democracy

* fix no-std final

* fix clippy

(cherry picked from commit 94cbcca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants