Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.devcontainer: upgrade to go 1.21 #1476

Merged
merged 1 commit into from
Oct 14, 2024
Merged

.devcontainer: upgrade to go 1.21 #1476

merged 1 commit into from
Oct 14, 2024

Conversation

echarrod
Copy link
Contributor

@encore-cla
Copy link

encore-cla bot commented Oct 13, 2024

All committers have signed the CLA.

@echarrod echarrod mentioned this pull request Oct 13, 2024
Closed
eandre
eandre approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@eandre eandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eandre eandre merged commit bcb54f3 into encoredev:main Oct 14, 2024
@echarrod echarrod mentioned this pull request Oct 14, 2024
Merged
fredr pushed a commit that referenced this pull request Oct 15, 2024
@echarrod
.devcontainer: upgrade to go 1.23 (#1483)
fbe032f 
- Thought I'd go conservative with
#1476, as I thought that was all
that was needed
- But now getting this when trying to open a codespace:
```shell
2024-10-14 16:54:48.017Z: #11 47.24 go: honnef.co/go/tools/cmd/staticcheck@master: honnef.co/go/tools@v0.6.0-0.dev.0.20241004131735-f6581d960da8 requires go >= 1.22.1 (running go 1.21.13; GOTOOLCHAIN=local)2024-10-14 16:54:48.018Z: 
```
- Thought there might be other libraries that have similar requirements,
so updated to 1.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eandre eandre eandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening project in codespaces doesn't work: module requires Go 1.21
2 participants
@echarrod @eandre