Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimes/core: propagate auth error from auth handler #1485

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

fredr
Copy link
Member

@fredr fredr commented Oct 15, 2024

Propagate auth errors from the auth handler

@fredr fredr requested a review from eandre October 15, 2024 07:26
@fredr fredr self-assigned this Oct 15, 2024
@fredr fredr force-pushed the fredr/ts-propagate-auth-error branch from f3eb214 to 6014044 Compare October 15, 2024 08:44
@encore-cla
Copy link

encore-cla bot commented Oct 15, 2024

All committers have signed the CLA.

@fredr fredr force-pushed the fredr/ts-propagate-auth-error branch 2 times, most recently from b7876c7 to 38b5199 Compare October 15, 2024 16:56
@fredr
Copy link
Member Author

fredr commented Oct 16, 2024

This also fixes a bug when we convert pingora errors to api errors in some cases 🐞

@fredr fredr force-pushed the fredr/ts-propagate-auth-error branch from 08bfb10 to d79ce24 Compare October 16, 2024 08:58
@fredr fredr enabled auto-merge (squash) October 16, 2024 08:58
@fredr fredr merged commit 86c4df8 into main Oct 16, 2024
4 checks passed
@fredr fredr deleted the fredr/ts-propagate-auth-error branch October 16, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants