PPC: Guess reloc data type based on the instruction. #108
Conversation
Adds an entry to the reloc tooltip to show the inferred data type and value.
| .and_then(|ty| arch.display_data_type(ty, &reloc.target.bytes)) | ||
| { | ||
| ui.colored_label(appearance.highlight_color, s); | ||
| } |
There was a problem hiding this comment.
Can we add this to the context menu as well? So you can copy the float value. Would require splitting out the label and value for display
There was a problem hiding this comment.
This was one of the things I wanted to do in a followup. It might be a bit before I can get the time again to figure it out.
|
@encounter What is your opinion on the |
|
I'm okay with either, though I agree it's a little confusing. |
|
@encounter I really don't like this solution to the matching on opcode problem. Do you have a better solution than transmuting? |
|
Transmuting is fine for now. Thanks for the work on this! |
…, and data relocation diffing (#166) * Show data literal values on instruction hover Reimplements #108 * Show reloc diffs in func view when data's content differs Reimplements #153 * Data diff view: Show relocs on hover and in context menu This reimplements #154 Note that colorizing the text depending on the kind of diff has still not been reimplemented yet * Fix up some comments
Adds an entry to the reloc tooltip to show the inferred data type and value.
This is potentially somewhat rough. I'm opening this get early feedback on the implementation. If this is deemed acceptable as is, it currently only implements PowerPC and I would be planning to follow up with a similar implementation for MIPS. I would also like to followup with an extension to the right-click context menu to copy the value of a reloc.
For integers: Unsigned and Signed interpretations are displayed (signed is only shown when value would be negative)
Arguably the string display should be removed as it may be somewhat confusing that it doesn't necessarily correspond to the string being used by the code.
Images:
