Implement context menu copy functionality for data values #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure the cargo deny failure isn't my fault right? |
|
Right, it looks like that's just a security advisory. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly this makes a minor change to the way negative integers are displayed. Now there will be separate tooltip entries for the signed and unsigned interpretations.
Code-wise under the hood formatting the data bytes has been decoupled from the data type prefix.
These changes allow the context menu to be extended with new options to copy data literals to the clipboard.
Future extensions may include interpretations of integers for other bases (especially base10), but I'm not sure if it would cause too much clutter in the tooltip menu for now.