Skip to content

Use symbol name when comparing against an externed reloc #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented May 30, 2025

For partial matching files, often a symbol is externed even though it should exist in the target object. We can still compare the symbol name, instead of always returning a mismatch.

I think this also fixes #210

For partial matching files, often a symbol is externed even though it
should exist in the target object. We can still compare the symbol name,
instead of always returning a mismatch.
@encounter
Copy link
Owner

Couple things:

  1. Let's combine this with the (None, None) case
  2. Could you also update the reloc_eq in diff/data.rs

@r-burns
Copy link
Contributor Author

r-burns commented May 30, 2025

cool I think I got it, is this what you meant?

@encounter
Copy link
Owner

Yes, looks good, thank you!

@encounter encounter merged commit f58616b into encounter:main May 30, 2025
24 checks passed
@r-burns r-burns deleted the externed-relocs branch May 30, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a relocation option for definition differences
2 participants