Let-else reformatting #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCondron
force-pushed
the
let-else-formats
branch
from
d5bbc98 to
40eccee
Compare
|
Thanks a lot! let-else is a big improvement. Would you mind updating rust-version in Cargo.toml to 1.65? Also, rebasing on main should fix CI. |
NickCondron
force-pushed
the
let-else-formats
branch
from
40eccee to
c72befd
Compare
|
Rebased and updated Cargo.toml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to use the let-else construct where it improves readability. I targeted the code sections that benefited the most. It is somewhat a stylistic/subjective decision in different cases, so I made each change a separate commit in case you want to drop one or more of them.