Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HKDF uses SHA-512, the native output size is 512 bit.
When HMAC uses SHA256, the internal block size is also 512 bit. If the key is shorter than the block size, it gets padded.
I.e. using a 256 bit key introduces unnecessary intermediate steps:
So let's simplify this to:
Not only does this remove unnecessary operations. Furthermore, truncating and then padding the key reduce the effective key size (assuming surrounding operations provide equally high security).