Partially revert "Remove obsolete cleanup of obsolete stamp files" #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts part of commit 1338aae. Sadly I had not realised that this stamp file was also created by a hook in the image builder. So on every new system installed between 3.5.0 and 6.0.1 inclusive, this stamp file was preinstalled and deleted on first boot; while on all systems installed with 6.0.2 or newer, the stamp file was preinstalled but never removed. endlessm/eos-image-builder@6d1389f removes the image builder hook, but for the sake of those systems installed with 6.0.2 or newer, reinstate the tmpfiles snippet that deletes the stamp file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of commit 1338aae.
Sadly I had not realised that this stamp file was also created by a hook in the image builder. So on every new system installed between 3.5.0 and 6.0.1 inclusive, this stamp file was preinstalled and deleted on first boot; while on all systems installed with 6.0.2 or newer, the stamp file was preinstalled but never removed.
endlessm/eos-image-builder#173 removes the image builder hook, but for the sake of those systems installed with 6.0.2 or newer, reinstate the tmpfiles snippet that deletes the stamp file.