Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra space in Support link #674

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

dylanmccall
Copy link
Collaborator

No description provided.

@dylanmccall
Copy link
Collaborator Author

dylanmccall commented Jun 25, 2023

Completely random, but for a long term solution this probably is a good starting point to learn some context around whitespace with (our version of) VueJS: vuejs/vue#9208.

Might be we should check on our build options? I don't see a reason why we wouldn't want to strip whitespace, although there could be some unforeseen consequences changing it at this point.

@GeorgesStavracas GeorgesStavracas merged commit 3dfab6f into master Jun 26, 2023
@GeorgesStavracas GeorgesStavracas deleted the dylanmccall-patch-1 branch June 26, 2023 12:02
@manuq
Copy link
Collaborator

manuq commented Jun 26, 2023

Nice, this whitespace bugged me a lot as well. One day I tried to fix it exactly like you did but the code formatting was silly reverting it. Great to know about the upstream issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants