Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redis] Add automation #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[redis] Add automation #126

wants to merge 1 commit into from

Conversation

igaskin
Copy link

@igaskin igaskin commented Jul 24, 2023

Relates to endoflife-date/endoflife.date#3261.

Could you help me understand how the automation interacts with the existing redis.json file? There seems to be some unwanted deletions caused by the running redis.py.

Parses the End-of-life schedule from: https://docs.redis.com/latest/rs/installing-upgrading/product-lifecycle/

$ python src/redis.py
::group::redis
6.2: 2024-08-31
6.0: 2022-05-31
5.6: 2021-10-31
5.4: 2020-12-31
5.2: 2019-12-31
::endgroup::

@captn3m0
Copy link
Member

Our file format currently only supports release dates, not EOL dates. Those are manually updated directly in the endoflife.date repository. We plan to add support for scraping EOL dates in this repo (#125), but that's still in planning.

Till that, maybe we can change this to a separate eol directory instead of releases for now so we can merge this? cc @marcwrobel

@igaskin
Copy link
Author

igaskin commented Jul 25, 2023

🤦🏾 that makes sense, that was a misunderstanding on my part. Thank you.

@marcwrobel
Copy link
Member

Till that, maybe we can change this to a separate eol directory instead of releases for now so we can merge this? cc @marcwrobel

The goal is in my (current) opinion to have all the data in the same file because I find it easier to manage that way. So I would rather wait until it is supported.

@marcwrobel
Copy link
Member

This is now possible, and for Redis it also maybe already natively supported through the release_table method (see examples on https://github.com/search?q=repo%3Aendoflife-date%2Fendoflife.date%20release_table&type=code) and documentation in https://github.com/endoflife-date/release-data/blob/main/src/release_table.py.

Note that https://redis.io/docs/latest/operate/rs/installing-upgrading/product-lifecycle/ may be only valid for Redis Enterprise, and https://endoflife.date/redis seems to document the OSS version. So maybe it would be better to create a separate product ?

@captn3m0
Copy link
Member

So maybe it would be better to create a separate product?

+1. We should also add the Redis forks.

I can't find good naming for the Source-Available Redis variant - we can't use "Redis Open Source". Maybe Redis Public/Community?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants