Upgrade boolean args to prop bags

endojs · Mar 15, 2022 · df12a0c · df12a0c
1 parent bde223e
commit df12a0c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/packages/init/node-async_hooks-patch.js b/packages/init/node-async_hooks-patch.js
@@ -1,3 +1,3 @@
 import { setup } from './node-async_hooks.js';
 
-setup(true);
+setup({ withDestroy: true });
diff --git a/packages/init/node-async_hooks.js b/packages/init/node-async_hooks.js
@@ -134,7 +134,7 @@ const findAsyncSymbolsFromPromiseCreateHook = () => {
   }
 };
 
-const getAsyncHookFallbackState = (promise, create) => {
+const getAsyncHookFallbackState = (promise, { create = false } = {}) => {
   let state = promiseAsyncHookFallbackStates.get(promise);
   if (!state && create) {
     state = {
@@ -150,7 +150,7 @@ const getAsyncHookFallbackState = (promise, create) => {
 };
 
 const setAsyncIdFallback = (promise, symbol, value) => {
-  const state = getAsyncHookFallbackState(promise, true);
+  const state = getAsyncHookFallbackState(promise, { create: true });
 
   if (state[symbol]) {
     if (state[symbol] !== value) {
@@ -163,7 +163,10 @@ const setAsyncIdFallback = (promise, symbol, value) => {
   }
 };
 
-const getAsyncHookSymbolPromiseProtoDesc = (symbol, disallowGet) => ({
+const getAsyncHookSymbolPromiseProtoDesc = (
+  symbol,
+  { disallowGet = false } = {},
+) => ({
   set(value) {
     if (Object.isExtensible(this)) {
       Object.defineProperty(this, symbol, {
@@ -181,14 +184,14 @@ const getAsyncHookSymbolPromiseProtoDesc = (symbol, disallowGet) => ({
     if (disallowGet) {
       return undefined;
     }
-    const state = getAsyncHookFallbackState(this, false);
+    const state = getAsyncHookFallbackState(this, { create: false });
     return state && state[symbol];
   },
   enumerable: false,
   configurable: true,
 });
 
-export const setup = (withDestroy = true) => {
+export const setup = ({ withDestroy = true } = {}) => {
   if (withDestroy) {
     findAsyncSymbolsFromPromiseCreateHook();
   } else {
@@ -216,7 +219,9 @@ export const setup = (withDestroy = true) => {
     Object.defineProperty(
       PromiseProto,
       Symbol.nodeAsyncHooksDestroyed,
-      getAsyncHookSymbolPromiseProtoDesc(Symbol.nodeAsyncHooksDestroyed, true),
+      getAsyncHookSymbolPromiseProtoDesc(Symbol.nodeAsyncHooksDestroyed, {
+        disallowGet: true,
+      }),
     );
   } else if (withDestroy) {
     // console.warn(`Couldn't find destroyed symbol to setup trap`);