Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export explicit types #1254

Open
7 of 38 tasks
turadg opened this issue Aug 16, 2022 · 0 comments
Open
7 of 38 tasks

export explicit types #1254

turadg opened this issue Aug 16, 2022 · 0 comments
Labels
endo kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024

Comments

@turadg
Copy link
Member

turadg commented Aug 16, 2022

Some @Endo packages export types ambiently. This leads to problems downstream like Agoric/agoric-sdk#4560

Some examples:

  • Module '"@endo/promise-kit"' has no exported member 'isPromise'

Instead @Endo packages should export types explicitly as in #1025

  • base64
  • bundle-source
  • captp
  • check-bundle
  • cjs-module-analyzer
  • cli
  • compartment-mapper
  • daemon
  • env-options
  • errors
  • eslint-plugin
  • evasive-transform
  • eventual-send
  • exo
  • far
  • import-bundle
  • init
  • lockdown
  • lp32
  • marshal
  • memoize
  • nat
  • netstring
  • pass-style
  • patterns
  • promise-kit
  • ses
  • ses-ava
  • ses-integration-test
  • skel
  • static-module-record
  • stream
  • stream-node
  • stream-types-test
  • syrup
  • test262-runner
  • where
  • zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endo kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024
Projects
None yet
Development

No branches or pull requests

3 participants