1254 import bundle #1366
Merged
1254 import bundle #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Nov 15, 2022
| @@ -52,6 +53,7 @@ export async function importBundle(bundle, options = {}) { | |||
| const { namespace } = await archive['import']({ | |||
| globals: endowments, | |||
| __shimTransforms__: transforms, | |||
| // @ts-expect-error TS2740 missing properties from type | |||
There was a problem hiding this comment.
I’m curious why Compartment is not more specifically typed here, since it should be in the /// <reference types="ses"/> above.
There was a problem hiding this comment.
The error message without it:
Type 'typeof Compartment' is missing the following properties from type 'Compartment': globalThis, evaluate, import, load, and 2 more.
fixes inclusion of Typescript 3
turadg
force-pushed
the
1254-import-bundle
branch
from
6e893bb
to
af89f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1254