Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ses-ava support for t.log #611

Closed
dckc opened this issue Mar 15, 2021 · 3 comments · Fixed by #2109
Closed

ses-ava support for t.log #611

dckc opened this issue Mar 15, 2021 · 3 comments · Fixed by #2109
Assignees
Labels
devex developer experience project Issues submitted for attention of project management at Agoric to communicate with stake-holders

Comments

@dckc
Copy link
Contributor

dckc commented Mar 15, 2021

from Agoric/agoric-sdk#2582 (comment) ...

our tests aren't supposed to console.log. t.log would be silent unless ava -v were used...

    t.log('expected failure', reason);

but it's not integrated with the SES console, so we get the boring...

  ✔ ses-ava-reject-deep-stacks › ses-ava reject console output
    ℹ expected failure TypeError {
        message: 'msg (a string)',
      }
@kriskowal kriskowal added the kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 label Jan 10, 2024
@erights
Copy link
Contributor

erights commented Mar 1, 2024

The boringness should be fixed by #2109

Whatever Ava's properties around quieting or verbosifying t.log, #2109 should preserve them. However, from my own testing of raw Ava I am not seeing that silence.

@dckc
Copy link
Contributor Author

dckc commented Mar 2, 2024

The "silent unless -v" aspect of ava went away in some version a while ago, IIRC.

@dckc dckc added the devex developer experience label Mar 4, 2024
@gibson042
Copy link
Contributor

The "silent unless -v" aspect of ava went away in some version a while ago, IIRC.

Yeah, looks like it was dropped as part of version 4: avajs/ava@0a6e2df

@erights erights self-assigned this Mar 4, 2024
@aj-agoric aj-agoric removed the kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 label Mar 6, 2024
@kriskowal kriskowal added the project Issues submitted for attention of project management at Agoric to communicate with stake-holders label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex developer experience project Issues submitted for attention of project management at Agoric to communicate with stake-holders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants