test(ses-ava): option to use t.log #2101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Feb 25, 2024
kriskowal
approved these changes
Feb 27, 2024
2 tasks
erights
force-pushed
the
markm-ses-ava-quieter-logging
branch
from
a0ce2a3 to
2458798
Compare
erights
changed the base branch from
master
to
markm-export-console-tools-support
erights
force-pushed
the
markm-export-console-tools-support
branch
from
87982e5 to
7a7ff1a
Compare
erights
force-pushed
the
markm-ses-ava-quieter-logging
branch
2 times, most recently
from
caf11d6 to
f1b5d40
Compare
|
This is now actually ready for review. Enough has changed since you approved that I request new approvals. (I have no idea how to clear the old ones, or even if that's possible.) Note that this PR now depends on, and is staged on, #2107, so that would need to get reviewed and merged before this one could. Please review that one too. It should be straightforward. |
erights
force-pushed
the
markm-ses-ava-quieter-logging
branch
2 times, most recently
from
7f8b02c to
92e34c9
Compare
erights
force-pushed
the
markm-ses-ava-quieter-logging
branch
from
92e34c9 to
4edbbbd
Compare
|
Converting to Draft. See #2107 (comment) |
erights
force-pushed
the
markm-ses-ava-quieter-logging
branch
from
8e3c1c6 to
37f2093
Compare
erights
force-pushed
the
markm-ses-ava-quieter-logging
branch
from
37f2093 to
650e719
Compare
|
Closing in favor of #2109 |
|
#2109 is sufficiently different that it needs a from-scratch review. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #2107
closes: #XXXX
refs: Agoric/agoric-sdk#8965 (comment) #611 #647 #891 #1467 #2107 Agoric/agoric-sdk#8662 #1798
Description
Alter ses-ava so that it ultimately uses
t.logto log errors or rejections from thet => {...}function.Security Considerations
As of this PR, ses-ava will import from
console-tools.js, as exported bysesin #2107 . We must ensure that this arrangement does not accidentally make these powers available to non-privileged code executing in constructed (non-start) compartments. See "Security Considerations" at #2107Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
The whole point. Since this PR changes only the logging of errors or rejections from the
t => {...}function, it will not by itself clean up console output in general. But at least it will cause these error reports to appear at the "right" place in the overall console output.Compatibility Considerations
Mostly none.
If there are programs post-processing our voluminous console output, they might need to change. However,
Upgrade Considerations
Nothing breaking. Nothing newsworthy as of this PR by itself.
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.