Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compartment-mapper): avoid mislabeling cjs files as esm based on type field 1 #1231

Closed
wants to merge 1 commit into from

Conversation

naugtur
Copy link
Member

@naugtur naugtur commented Jul 1, 2022

A version of the fix that doesn't introduce assumptions about language vs extension into the makeExtensionParser function, but at a cost of parsing extensions in graphPackage where it aggregates types.

An alternative: #1230

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like #1230 more but trust your judgement if stacking these changes helps.

@naugtur
Copy link
Member Author

naugtur commented Jul 21, 2022

I'm looking at a choice between stacking this onto the other solution so that types field doesn't contain lies OR renaming types to indicate it's not the final verdict on the module type.

Renaming would be an obvious choice but the rename propagates across the codebase further than I'd want it to - which made me hesitate.
Not closing this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants