Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1593, the bundler and compartment-mapper read many files to build a bundle and these reads are by default aggressively concurrent. This can lead to the exhaustion of file descriptors. This is generally silly because a file system does not tend to improve throughput with any amount of concurrency.
However, the compartment mapper is sufficiently general to run on any read powers, so it would be poor form to use a synchronous read function.
With this change, the compartment mapper classifies read errors in Node.js:
…and monitors the throughput of reads. The governor implements an hybrid control loop based on AIMD (additive increase, multiplicative decrease) and CoDel (control delay).
And we also incidentally are more careful to distinguish these errors from missing entries when searching for a file (
maybeRead
).A worthy critique of this PR is: perhaps instead of this level of sophistication you could just limit the Node.js read powers to a single concurrent read.