pattern types #1721
Draft
pattern types #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/pattern-types
branch
from
8845ba4 to
950cd7f
Compare
gibson042
reviewed
Aug 14, 2023
Comment on lines
+99
to
104
| * @template {string} [T=string] tag | ||
| * @typedef {{ | ||
| * [Symbol.toStringTag]: string, | ||
| * [Symbol.toStringTag]: T, | ||
| * payload: Passable, | ||
| * [passStyle: symbol]: 'tagged' | string, | ||
| * }} CopyTagged |
There was a problem hiding this comment.
Won't this equate CopyTagged with CopyTagged<string>, which is novel and unexpected because "string" is not a known tag?
There was a problem hiding this comment.
hmm, I don't think CopyTagged<string> would satisfy the template because the parameter wouldn't be a string itself. It would have to by CopyTagged<'string'>. That's not a known tag but it was valid before, right? (i.e. not a regression).
| if (harden.isFake) { | ||
| if ('isFake' in harden) { |
There was a problem hiding this comment.
What motivates these changes?
There was a problem hiding this comment.
the line started erroring because harden doesn't have an isFake property. I figure something in my changes fixed a resolution that had been falling back to any
mergify bot
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jul 12, 2024
refs: #6160 ## Description I ran again into the need for type narrowing with a shape object: https://github.com/Agoric/agoric-sdk/pull/8385/files#diff-b17d46d065ac769cdf1d70471b16d141f28672965c18522d58d39722d4852ad4R329-R331 endojs/endo#1721 approached the general problem of inferring the type from the shape. But until we have that, we can at least move the type description onto the shape object so users of that shape can automatically get the type a match implies. With this, the code referenced above would be, ```js const questionDesc = cast(info, QuestionSpecShape); ``` ### Security Considerations n/a ### Scaling Considerations n/a ### Documentation Considerations Once this settles in agoric-sdk, we may want to move it into Endo. Alternately, Endo waits for more general support. ### Testing Considerations Has a test. Maybe should use tsd instead of Ava ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #2392
Description
Make
mustMatchassert type implied by matcher.TODO: rebase onto master. I have a working branch for that but it needs more work before overwriting this remote.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations