Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc tightening of linting #2615

Merged
merged 11 commits into from
Oct 25, 2024
Merged

misc tightening of linting #2615

merged 11 commits into from
Oct 25, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 24, 2024

incidental

Description

Adopting verbatimModuleSyntax in agoric-sdk required a lot of changes so it thought it worthwhile to adopt here before more might be necessary.

I made several other lint tooling bumps and config tightening as well.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

CI

Compatibility Considerations

none

Upgrade Considerations

none, dev deps

@turadg turadg requested a review from kriskowal October 24, 2024 22:07
Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lint warning in the build, but that looks like an eslint-plugin-jsdoc bug to me. workaround would be to rename the array parameter to something else

Unclear if we should split the dependency upgrades into a separate PR

@turadg turadg enabled auto-merge October 25, 2024 22:56
@turadg
Copy link
Member Author

turadg commented Oct 25, 2024

There's a lint warning in the build, but that looks like an eslint-plugin-jsdoc bug to me. workaround would be to rename the array parameter to something else

Yeah, I agree it's a bug. It was there before this PR so I'm going to overlook it.

Unclear if we should split the dependency upgrades into a separate PR

I separated all the commits. What would be the advantage of also separating PRs? Having a different set of reviewers, but that's not necessary in this case.

@turadg turadg merged commit d6c6c69 into master Oct 25, 2024
15 checks passed
@turadg turadg deleted the ta/tighten-lint branch October 25, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants