-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc tightening of linting #2615
Conversation
a91a3a7
to
4805361
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lint warning in the build, but that looks like an eslint-plugin-jsdoc
bug to me. workaround would be to rename the array
parameter to something else
Unclear if we should split the dependency upgrades into a separate PR
4805361
to
7b5d004
Compare
Yeah, I agree it's a bug. It was there before this PR so I'm going to overlook it.
I separated all the commits. What would be the advantage of also separating PRs? Having a different set of reviewers, but that's not necessary in this case. |
incidental
Description
Adopting
verbatimModuleSyntax
in agoric-sdk required a lot of changes so it thought it worthwhile to adopt here before more might be necessary.I made several other lint tooling bumps and config tightening as well.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI
Compatibility Considerations
none
Upgrade Considerations
none, dev deps