Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ses): Finish embracing permits terminology #2619

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

kriskowal
Copy link
Member

Description

Internally, SES uses the term “whitelist” and “permits” interchangeably. This change attempts to regularize this terminology, favoring “permit”, “permits”, “permitted”, and “unpermitted” throughout.
The only user-visible effects appear in error messages.

Security Considerations

None.

Scaling Considerations

None.

Documentation Considerations

Addressed.

Testing Considerations

None.

Compatibility Considerations

There is some risk that this will frustrate tests that over-constrain on error message patterns.

Upgrade Considerations

None.

@kriskowal kriskowal requested a review from erights October 28, 2024 22:13
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up. The inconsistency was bugging me too ;)

Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kriskowal kriskowal merged commit 08d3945 into master Oct 28, 2024
15 checks passed
@kriskowal kriskowal deleted the kriskowal-permit-terminology branch October 28, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants