fix(ses): Consistently name console methods #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Dec 6, 2024
gibson042
force-pushed
the
gibson-2024-12-console-method-names
branch
from
38accce to
fa7a1c4
Compare
gibson042
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2643
Ref 5e8fd33
Description
Unify the inconsistent approaches to creating [virtual] console functions with appropriate "name" properties.
Security Considerations
None.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
I don't think these details are covered by testing, but it seems like an acceptable gap for now.
Compatibility Considerations
None.
Upgrade Considerations
None.