Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EReturn type #2659

Merged
merged 3 commits into from
Dec 12, 2024
Merged

EReturn type #2659

merged 3 commits into from
Dec 12, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Dec 11, 2024

incidental

Description

Migrated from Agoric/agoric-sdk#9011

Define an EReturn type for the Awaited<ReturnType< pattern.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

This will appear in TSdoc

Testing Considerations

has tests

Compatibility Considerations

none

Upgrade Considerations

none

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is a good utility to make available.

I pushed some other changes to dedupe @endo/far type aliases and export EReturn from that package as well. PTAL and feel free to merge when satisfied.

@turadg turadg enabled auto-merge December 12, 2024 01:18
@turadg turadg merged commit 5df9122 into master Dec 12, 2024
14 of 15 checks passed
@turadg turadg deleted the ta/EReturn branch December 12, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants