add enablements to fix tape-4.x #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as ready-for-review in the hopes of making it trigger CI (I didn't think draft-ness would inhibit CI). But I expect it to fail tests. |
|
@erights: should I also add Also, I updated |
|
Not in this pr. I’ll take this on afterwards |
|
An update for |
This adds `FunctionPrototype.apply`, as well as `.message` for all the various Error prototypes, to the enablements list. This allows tape-4.x to be imported after lockdown, as well as fixing tape's t.throws() method. refs #293, but does not close it because tape-5.x is still broken
warner
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
May 28, 2020
with a (manually) patched SES-0.7.7 (incorporating endojs/endo#312), we can also install-ses before importing tape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
FunctionPrototype.apply, as well as.messagefor all thevarious Error prototypes, to the enablements list.
This allows tape-4.x to be imported after lockdown, as well as fixing tape's
t.throws() method.
refs #293, but does not close it because tape-5.x is still broken
Note: this currently fails local tests, I think because we have assertions that these items are not on the list. I'd appreciate some pointers as to how to fix these.