Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config override taming for better vscode debugging experience #559

Merged
merged 9 commits into from
Jan 18, 2021
Merged

Config override taming for better vscode debugging experience #559

merged 9 commits into from
Jan 18, 2021

Conversation

erights
Copy link
Contributor

@erights erights commented Jan 16, 2021

No description provided.

@erights erights mentioned this pull request Jan 16, 2021
Closed
@erights erights requested a review from kriskowal January 16, 2021 05:41
@erights erights marked this pull request as ready for review January 17, 2021 06:27
@erights erights requested a review from kriskowal January 17, 2021 06:30
@erights erights self-assigned this Jan 18, 2021
@erights erights requested a review from michaelfig January 18, 2021 19:31
michaelfig
michaelfig approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erights erights merged commit 0d6eff8 into master Jan 18, 2021
@erights erights deleted the override_safety branch January 18, 2021 21:15
@dckc dckc mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

@kriskowal kriskowal Awaiting requested review from kriskowal

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erights @kriskowal @michaelfig