WIP Stop enabling O.p.constructor #569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-stop-enabling-O-p-constructor
branch
from
c421fba to
a5b165b
Compare
|
Closing in favor of #587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. Blocked by Agoric/agoric-sdk#2324
SES by default currently enables
Object.prototype.constructorto be overridden. This PR would like to retire that as it causes the Node console to display objects in a confusing manner, likeHowever, agoric-sdk is currently not compatible with this improvement for two reasons.
Until that later problem is diagnosed and fixed, this PR remains a WIP Draft.