Symbol.toStringTag dominates default q stringify #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
changed the title
|
Given the progress on #2018, this is now ready for review. (In fact, this did not need to wait on that. It did not have the conflict with the old |
Chris-Hibbert
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an object had a property named by the
Symbol.toStringTagsymbol and it was empty, then the human readable "quoted" printing byqwould be"[<value of that property>]".This PR removes the "and it was empty" part of that condition. This PR should wait until Agoric/agoric-sdk#2018 is closed, because until then data objects, whether empty or not, will pass this test, preventing
qfrom providing a pleasant display of their properties.Until then, however, we have a painful difference in how
qrenders a remotable vs a remote presence of that remotable. Currently, for our objects-as-closures style of remotable,qwill show the method names. This difference means thatt.throwstests will see different quoted text in error messages depending on where the error was thrown. Attn @Chris-Hibbert