Skip to content

Commit

Permalink
gossmap: delete channels from map when deleted from store
Browse files Browse the repository at this point in the history
This addresses a crash where a deleted channel is added to the
txout_failures map, and temporarily ignored, but a reference is still
kept in the gossmap.  When the channel expires fromt the txout_failures
map, it is once again looked up in the gossmap, leading to a crash while
accessing a deleted entry.

Fixes ElementsProject#7689

Changelog-Fixed: Fixes a crash in gossipd accessing a deleted channel.
  • Loading branch information
endothermicdev committed Oct 4, 2024
1 parent 538a007 commit 1d93f20
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions gossipd/gossmap_manage.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@ static void remove_channel(struct gossmap_manage *gm,
GOSSIP_STORE_DYING_BIT,
WIRE_NODE_ANNOUNCEMENT);
}
gossmap_remove_chan(gossmap, chan);
}

static u32 get_timestamp(struct gossmap *gossmap,
Expand Down

0 comments on commit 1d93f20

Please sign in to comment.