-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(issuer): Enable the batchIssue() method in ERC1888 #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
josipbagaric
commented
Jun 15, 2021
•
edited
Loading
edited
- Add support for Batch issuing
- Only generate the validity function on-chain
- Update ERC-1888 to the latest spec on ERC-1888: Transferable Certificate (Claim) ethereum/EIPs#1888
- Move batch actions into a separate facade
josipbagaric
added
bug
Something isn't working
enhancement
New feature or request
labels
Jun 15, 2021
josipbagaric
force-pushed
the
chore/batch-issuance
branch
from
June 16, 2021 17:35
1a72a93
to
4e7f321
Compare
josipbagaric
force-pushed
the
chore/batch-issuance
branch
from
June 17, 2021 11:31
6982718
to
1c65518
Compare
@kosecki123 added some more comments to the smart contracts in the meantime. Now ready for a review again. |
josipbagaric
force-pushed
the
chore/batch-issuance
branch
2 times, most recently
from
June 18, 2021 05:51
bdc65b3
to
f90047c
Compare
josipbagaric
commented
Jun 18, 2021
kosecki123
approved these changes
Jun 18, 2021
packages/traceability/issuer/src/blockchain-facade/CertificateBatchOperations.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.