Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MSBuild/V2022 and clickable data collection fixes #124

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

mcphailtom
Copy link
Contributor

  • Updated Lua to 5.4.6
  • extract_clickabledata.lua updated to use table.unpack() instead of deprecated unpack (was no longer working for some modules since 2.9.1.48335 update e.g. F-15E)
  • modified build_plugin.bat to use MSBuild and copy runtime/lua DLLs
  • Lua and JSON managed with NuGet

@mcphailtom
Copy link
Contributor Author

seems like the build action never actually ran

@mcphailtom
Copy link
Contributor Author

I am using this version myself. The sln opens in VSCE 2022 and compiles cleanly with the only real functional difference being the lua library and minor change to the clickable data collection lua script.

@charlestytler
Copy link
Collaborator

seems like the build action never actually ran

Thanks for putting up the PR! I was just looking at my github actions and pushed an update to the triggers on master so I think it might work better with pull requests -- this is my first external PR on this repo so still learning 😄. If you don't mind merging in master I think it will run them. Otherwise, I can update my MSBuild version and test on my machine this weekend before merging.

One other nitpick: I've tried to exclude *.vcxproj.user files in my .gitignore, do you have any idea why that didn't work on your PR?

Changes look good to me other than that.

@mcphailtom
Copy link
Contributor Author

Hey @charlestytler no worries at all and thanks for taking a peek. I'll have a look at the .gitignore this afternoon and fix that up with an update. I think it would require at least a review from you for me to merge otherwise.

Signed-off-by: Tom McPhail <mcphailtom@github.com>
@mcphailtom
Copy link
Contributor Author

Updated 👍

@mcphailtom
Copy link
Contributor Author

Will probably need to update actions to run the newer MSBuild

@charlestytler charlestytler merged commit a784118 into enertial:master Dec 27, 2023
2 of 3 checks passed
@charlestytler
Copy link
Collaborator

I added on a couple commits to get the action working again, and fixed the setup so NuGet packages are restored fresh as part of the build process. This PR was incorporated in with #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants