Skip to content

Commit 1e822ca

Browse files
author
Jonah Williams
authored
Disable debug banner to stabilize impeller goldens. (#143794)
Fixes some of flutter/flutter#143616 by disabling the debug banner, which does not appear to be a critical part of the golden.
1 parent f9b3b84 commit 1e822ca

File tree

3 files changed

+16
-0
lines changed

3 files changed

+16
-0
lines changed

‎packages/flutter/test/material/snack_bar_test.dart‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2797,6 +2797,7 @@ void main() {
27972797

27982798
testWidgets('Material2 - SnackBars should be shown above the bottomSheet', (WidgetTester tester) async {
27992799
await tester.pumpWidget(MaterialApp(
2800+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
28002801
theme: ThemeData(useMaterial3: false),
28012802
home: const Scaffold(
28022803
bottomSheet: SizedBox(
@@ -3142,6 +3143,7 @@ void main() {
31423143
// Regression test for https://github.com/flutter/flutter/issues/98205
31433144
await tester.pumpWidget(MaterialApp(
31443145
theme: ThemeData(useMaterial3: false),
3146+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
31453147
home: Scaffold(
31463148
body: const Scaffold(),
31473149
floatingActionButton: FloatingActionButton(onPressed: () {}),
@@ -3175,6 +3177,7 @@ void main() {
31753177
// Regression test for https://github.com/flutter/flutter/issues/98205
31763178
await tester.pumpWidget(MaterialApp(
31773179
theme: ThemeData(useMaterial3: true),
3180+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
31783181
home: Scaffold(
31793182
body: const Scaffold(),
31803183
floatingActionButton: FloatingActionButton(onPressed: () {}),
@@ -3207,6 +3210,7 @@ void main() {
32073210
testWidgets('Floating snackbar can display optional icon', (WidgetTester tester) async {
32083211
await tester.pumpWidget(MaterialApp(
32093212
theme: ThemeData(useMaterial3: false),
3213+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
32103214
home: const Scaffold(
32113215
bottomSheet: SizedBox(
32123216
width: 200,
@@ -3239,6 +3243,7 @@ void main() {
32393243
testWidgets('Material2 - Fixed width snackbar can display optional icon', (WidgetTester tester) async {
32403244
await tester.pumpWidget(MaterialApp(
32413245
theme: ThemeData(useMaterial3: false),
3246+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
32423247
home: const Scaffold(
32433248
bottomSheet: SizedBox(
32443249
width: 200,
@@ -3266,6 +3271,7 @@ void main() {
32663271
testWidgets('Material3 - Fixed width snackbar can display optional icon', (WidgetTester tester) async {
32673272
await tester.pumpWidget(MaterialApp(
32683273
theme: ThemeData(useMaterial3: true),
3274+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
32693275
home: const Scaffold(
32703276
bottomSheet: SizedBox(
32713277
width: 200,
@@ -3293,6 +3299,7 @@ void main() {
32933299
testWidgets('Material2 - Fixed snackbar can display optional icon without action', (WidgetTester tester) async {
32943300
await tester.pumpWidget(MaterialApp(
32953301
theme: ThemeData(useMaterial3: false),
3302+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
32963303
home: const Scaffold(
32973304
bottomSheet: SizedBox(
32983305
width: 200,
@@ -3321,6 +3328,7 @@ void main() {
33213328
testWidgets('Material3 - Fixed snackbar can display optional icon without action', (WidgetTester tester) async {
33223329
await tester.pumpWidget(MaterialApp(
33233330
theme: ThemeData(useMaterial3: true),
3331+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
33243332
home: const Scaffold(
33253333
bottomSheet: SizedBox(
33263334
width: 200,
@@ -3349,6 +3357,7 @@ void main() {
33493357
testWidgets('Material2 - Floating width snackbar can display optional icon without action', (WidgetTester tester) async {
33503358
await tester.pumpWidget(MaterialApp(
33513359
theme: ThemeData(useMaterial3: false),
3360+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
33523361
home: const Scaffold(
33533362
bottomSheet: SizedBox(
33543363
width: 200,
@@ -3375,6 +3384,7 @@ void main() {
33753384
testWidgets('Material3 - Floating width snackbar can display optional icon without action', (WidgetTester tester) async {
33763385
await tester.pumpWidget(MaterialApp(
33773386
theme: ThemeData(useMaterial3: true),
3387+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
33783388
home: const Scaffold(
33793389
bottomSheet: SizedBox(
33803390
width: 200,
@@ -3401,6 +3411,7 @@ void main() {
34013411
testWidgets('Material2 - Floating multi-line snackbar with icon is aligned correctly', (WidgetTester tester) async {
34023412
await tester.pumpWidget(MaterialApp(
34033413
theme: ThemeData(useMaterial3: false),
3414+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
34043415
home: const Scaffold(
34053416
bottomSheet: SizedBox(
34063417
width: 200,
@@ -3428,6 +3439,7 @@ void main() {
34283439
testWidgets('Material3 - Floating multi-line snackbar with icon is aligned correctly', (WidgetTester tester) async {
34293440
await tester.pumpWidget(MaterialApp(
34303441
theme: ThemeData(useMaterial3: true),
3442+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
34313443
home: const Scaffold(
34323444
bottomSheet: SizedBox(
34333445
width: 200,
@@ -3455,6 +3467,7 @@ void main() {
34553467
testWidgets('Material2 - Floating multi-line snackbar with icon and actionOverflowThreshold=1 is aligned correctly', (WidgetTester tester) async {
34563468
await tester.pumpWidget(MaterialApp(
34573469
theme: ThemeData(useMaterial3: false),
3470+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
34583471
home: const Scaffold(
34593472
bottomSheet: SizedBox(
34603473
width: 200,
@@ -3485,6 +3498,7 @@ void main() {
34853498
testWidgets('Material3 - Floating multi-line snackbar with icon and actionOverflowThreshold=1 is aligned correctly', (WidgetTester tester) async {
34863499
await tester.pumpWidget(MaterialApp(
34873500
theme: ThemeData(useMaterial3: true),
3501+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
34883502
home: const Scaffold(
34893503
bottomSheet: SizedBox(
34903504
width: 200,

‎packages/flutter/test/material/value_indicating_slider_test.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -405,6 +405,7 @@ Future<void> _buildValueIndicatorStaticSlider(
405405
}) async {
406406
await tester.pumpWidget(
407407
MaterialApp(
408+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
408409
theme: ThemeData(useMaterial3: useMaterial3),
409410
home: Scaffold(
410411
body: Builder(

‎packages/flutter/test/widgets/color_filter_test.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ void main() {
4040
child: ColorFiltered(
4141
colorFilter: sepia,
4242
child: MaterialApp(
43+
debugShowCheckedModeBanner: false, // https://github.com/flutter/flutter/issues/143616
4344
title: 'Flutter Demo',
4445
theme: ThemeData(primarySwatch: Colors.blue, useMaterial3: false),
4546
home: Scaffold(

0 commit comments

Comments
 (0)