Skip to content

Commit

Permalink
Resolve TODOs in channels integration test (#130745)
Browse files Browse the repository at this point in the history
They were helpful in diagnosing the flake in flutter/flutter#116663, but now that that's resolved they have outlived their usefulness. Let's remove 'em!
  • Loading branch information
goderbauer authored Jul 17, 2023
1 parent ede545c commit 2dbf594
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// found in the LICENSE file.

import 'package:channels/main.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';

Expand All @@ -14,9 +13,6 @@ String getStatus(WidgetTester tester) => tester.widget<Text>(statusField).data!;

void main() {
testWidgets('step through', (WidgetTester tester) async {
// TODO(goderbauer): Remove this once https://github.com/flutter/flutter/issues/116663 is diagnosed.
debugPrintHitTestResults = true;

await tester.pumpWidget(const TestApp());
await tester.pumpAndSettle();

Expand All @@ -37,9 +33,6 @@ void main() {
}
}

// TODO(goderbauer): Remove this once https://github.com/flutter/flutter/issues/116663 is diagnosed.
debugPrintHitTestResults = false;

final String status = getStatus(tester);
if (status != 'complete') {
fail('Failed at step $step with status $status');
Expand Down

0 comments on commit 2dbf594

Please sign in to comment.