Give error on too many arguments to flutter config (#121494)

Give error on too many arguments to `flutter config`
engine-flutter-autoroll · Feb 27, 2023 · 516b60b · 516b60b
1 parent a297cb3
commit 516b60b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/packages/flutter_tools/lib/src/commands/config.dart b/packages/flutter_tools/lib/src/commands/config.dart
@@ -101,6 +101,16 @@ class ConfigCommand extends FlutterCommand {
 
   @override
   Future<FlutterCommandResult> runCommand() async {
+    final List<String> rest = argResults?.rest ?? <String>[];
+    if (rest.isNotEmpty) {
+      throwToolExit(exitCode: 2,
+          'error: flutter config: Too many arguments.\n'
+          '\n'
+          'If a value has a space in it, enclose in quotes on the command line\n'
+          'to make a single argument.  For example:\n'
+          '    flutter config --android-studio-dir "/opt/Android Studio"');
+    }
+
     if (boolArgDeprecated('machine')) {
       await handleMachine();
       return FlutterCommandResult.success();

diff --git a/packages/flutter_tools/test/commands.shard/hermetic/config_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/config_test.dart
@@ -44,6 +44,19 @@ void main() {
   }
 
   group('config', () {
+    testUsingContext('throws error on excess arguments', () {
+      final ConfigCommand configCommand = ConfigCommand();
+      final CommandRunner<void> commandRunner = createTestCommandRunner(configCommand);
+
+      expect(() => commandRunner.run(<String>[
+        'config',
+        '--android-studio-dir=/opt/My', 'Android', 'Studio',
+      ]), throwsToolExit());
+      verifyNoAnalytics();
+    }, overrides: <Type, Generator>{
+      Usage: () => testUsage,
+    });
+
     testUsingContext('machine flag', () async {
       final ConfigCommand command = ConfigCommand();
       await command.handleMachine();