Cover more test/widgets tests with leak tracking (#134387)

engine-flutter-autoroll · Sep 13, 2023 · 7d0c9b7 · 7d0c9b7
1 parent 083ac65
commit 7d0c9b7
Show file tree

Hide file tree

Showing 15 changed files with 1,209 additions and 1,070 deletions.
diff --git a/packages/flutter/test/widgets/app_test.dart b/packages/flutter/test/widgets/app_test.dart
@@ -306,7 +306,7 @@ void main() {
     expect(find.text('popped'), findsOneWidget);
   },
   leakTrackingTestConfig: const LeakTrackingTestConfig(
-    // TODO(someone): remove after fixing
+    // TODO(ksokolovskyi): remove after fixing
     // https://github.com/flutter/flutter/issues/134205
     notDisposedAllowList: <String, int?> {'_RestorableRouteInformation': 1},
   ));
@@ -338,7 +338,7 @@ void main() {
     expect(find.text('popped'), findsOneWidget);
   },
   leakTrackingTestConfig: const LeakTrackingTestConfig(
-    // TODO(someone): remove after fixing
+    // TODO(ksokolovskyi): remove after fixing
     // https://github.com/flutter/flutter/issues/134205
     notDisposedAllowList: <String, int?> {'_RestorableRouteInformation': 1},
   ));
@@ -434,7 +434,7 @@ void main() {
     expect(find.text('popped'), findsOneWidget);
   },
   leakTrackingTestConfig: const LeakTrackingTestConfig(
-    // TODO(someone): remove after fixing
+    // TODO(ksokolovskyi): remove after fixing
     // https://github.com/flutter/flutter/issues/134205
     notDisposedAllowList: <String, int?> {'_RestorableRouteInformation': 1},
   ));
@@ -455,7 +455,7 @@ void main() {
     expect(find.text('/'), findsOneWidget);
   },
   leakTrackingTestConfig: const LeakTrackingTestConfig(
-    // TODO(someone): remove after fixing
+    // TODO(ksokolovskyi): remove after fixing
     // https://github.com/flutter/flutter/issues/134205
     notDisposedAllowList: <String, int?> {'_RestorableRouteInformation': 1},
   ));

diff --git a/packages/flutter/test/widgets/draggable_test.dart b/packages/flutter/test/widgets/draggable_test.dart
diff --git a/packages/flutter/test/widgets/drawer_test.dart b/packages/flutter/test/widgets/drawer_test.dart
@@ -8,12 +8,13 @@ import 'package:flutter/gestures.dart' show DragStartBehavior;
 import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 
 import 'semantics_tester.dart';
 
 void main() {
 
-  testWidgets('Drawer control test', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Drawer control test', (WidgetTester tester) async {
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
     late BuildContext savedContext;
     await tester.pumpWidget(
@@ -44,7 +45,7 @@ void main() {
     expect(find.text('drawer'), findsNothing);
   });
 
-  testWidgets('Drawer tap test', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Drawer tap test', (WidgetTester tester) async {
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
     await tester.pumpWidget(
       MaterialApp(
@@ -76,7 +77,7 @@ void main() {
     expect(find.text('drawer'), findsNothing);
   });
 
-  testWidgets('Drawer hover test', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Drawer hover test', (WidgetTester tester) async {
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
     final List<String> logs = <String>[];
     final TestGesture gesture = await tester.createGesture(kind: PointerDeviceKind.mouse);
@@ -146,7 +147,7 @@ void main() {
     logs.clear();
   });
 
-  testWidgets('Drawer drag cancel resume (LTR)', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Drawer drag cancel resume (LTR)', (WidgetTester tester) async {
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
     await tester.pumpWidget(
       MaterialApp(
@@ -197,7 +198,7 @@ void main() {
     await gesture.up();
   });
 
-  testWidgets('Drawer drag cancel resume (RTL)', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Drawer drag cancel resume (RTL)', (WidgetTester tester) async {
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
     await tester.pumpWidget(
       MaterialApp(
@@ -251,7 +252,7 @@ void main() {
     await gesture.up();
   });
 
-  testWidgets('Drawer navigator back button', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Drawer navigator back button', (WidgetTester tester) async {
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
     bool buttonPressed = false;
 
@@ -299,7 +300,7 @@ void main() {
     expect(buttonPressed, equals(true));
   });
 
-  testWidgets('Dismissible ModalBarrier includes button in semantic tree', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Dismissible ModalBarrier includes button in semantic tree', (WidgetTester tester) async {
     final SemanticsTester semantics = SemanticsTester(tester);
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
 
@@ -326,7 +327,7 @@ void main() {
     semantics.dispose();
   }, variant: const TargetPlatformVariant(<TargetPlatform>{ TargetPlatform.iOS,  TargetPlatform.macOS }));
 
-  testWidgets('Dismissible ModalBarrier is hidden on Android (back button is used to dismiss)', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Dismissible ModalBarrier is hidden on Android (back button is used to dismiss)', (WidgetTester tester) async {
     final SemanticsTester semantics = SemanticsTester(tester);
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
 
@@ -354,7 +355,7 @@ void main() {
     semantics.dispose();
   }, variant: TargetPlatformVariant.only(TargetPlatform.android));
 
-  testWidgets('Drawer contains route semantics flags', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('Drawer contains route semantics flags', (WidgetTester tester) async {
     final SemanticsTester semantics = SemanticsTester(tester);
     final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
 

diff --git a/packages/flutter/test/widgets/dual_transition_builder_test.dart b/packages/flutter/test/widgets/dual_transition_builder_test.dart
@@ -4,13 +4,15 @@
 
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 
 void main() {
-  testWidgets('runs animations', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('runs animations', (WidgetTester tester) async {
     final AnimationController controller = AnimationController(
       vsync: const TestVSync(),
       duration: const Duration(milliseconds: 300),
     );
+    addTearDown(controller.dispose);
 
     await tester.pumpWidget(Center(
       child: DualTransitionBuilder(
@@ -74,11 +76,12 @@ void main() {
     expect(_getOpacity(tester), 1.0);
   });
 
-  testWidgets('keeps state', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('keeps state', (WidgetTester tester) async {
     final AnimationController controller = AnimationController(
       vsync: const TestVSync(),
       duration: const Duration(milliseconds: 300),
     );
+    addTearDown(controller.dispose);
 
     await tester.pumpWidget(Directionality(
       textDirection: TextDirection.ltr,
@@ -138,11 +141,13 @@ void main() {
     expect(state, same(tester.state(find.byType(_StatefulTestWidget))));
   });
 
-  testWidgets('does not jump when interrupted - forward', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('does not jump when interrupted - forward', (WidgetTester tester) async {
     final AnimationController controller = AnimationController(
       vsync: const TestVSync(),
       duration: const Duration(milliseconds: 300),
     );
+    addTearDown(controller.dispose);
+
     await tester.pumpWidget(Center(
       child: DualTransitionBuilder(
         animation: controller,
@@ -202,12 +207,14 @@ void main() {
     expect(_getOpacity(tester), 1.0);
   });
 
-  testWidgets('does not jump when interrupted - reverse', (WidgetTester tester) async {
+  testWidgetsWithLeakTracking('does not jump when interrupted - reverse', (WidgetTester tester) async {
     final AnimationController controller = AnimationController(
       value: 1.0,
       vsync: const TestVSync(),
       duration: const Duration(milliseconds: 300),
     );
+    addTearDown(controller.dispose);
+
     await tester.pumpWidget(Center(
       child: DualTransitionBuilder(
         animation: controller,