Skip to content

Commit

Permalink
[Windows_android channels_integration_test] Column -> ListView (#134836)
Browse files Browse the repository at this point in the history
This should fix flutter/flutter#134636. 

The column can get really tall, especially when there's line wrapping. This is the layout on a tablet, so on a motor g4 this column is likely going to overflow.

```
     RenderParagraph#66251 relayoutBoundary=up3
� creator: RichText � Text-[<'status'>] � Column �
�   FutureBuilder<TestStepResult> � Padding �
�   KeyedSubtree-[GlobalKey#0f29e] � _BodyBuilder � MediaQuery �
�   LayoutId-[<_ScaffoldSlot.body>] � CustomMultiChildLayout �
�   _ActionsScope � Actions � �
|  parentData: offset=Offset(0.0, 600.0); flex=null; fit=null
```

![flutter_01](https://github.com/flutter/flutter/assets/31859944/5e700d21-3c5e-4990-bfb5-153f44f1c517)
  • Loading branch information
LongCatIsLooong authored Sep 15, 2023
1 parent 43260cc commit ec47148
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions dev/integration_tests/channels/lib/src/test_step.dart
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ class TestStepResult {
);

Widget asWidget(BuildContext context) {
return Column(
crossAxisAlignment: CrossAxisAlignment.start,
return ListView(
children: <Widget>[
Text('Step: $name', style: bold),
Text(description),
Expand Down

0 comments on commit ec47148

Please sign in to comment.