Skip to content

retrieve token from api with username and password #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2015
Merged

Conversation

ehowe
Copy link
Contributor

@ehowe ehowe commented Jul 25, 2015

No description provided.

@lanej
Copy link
Contributor

lanej commented Jul 25, 2015

might cleaner to do a options.fetch(:token) so that it doesn't default. you wouldn't need any of the type logic.

@ehowe
Copy link
Contributor Author

ehowe commented Jul 25, 2015

Honestly, I'd rather do it explicitly rather than implicitly through a lack of token being passed. Mostly because the token is already implicit from the dotfile, so a fetch without a default doesn't really gain us anything here. I think the type logic would be needed either way

@lanej
Copy link
Contributor

lanej commented Jul 25, 2015

it would pretty explicit if you pass token: nil to the initializer.

@ehowe
Copy link
Contributor Author

ehowe commented Jul 25, 2015

Oh. I see...

@ehowe ehowe force-pushed the token-login branch 2 times, most recently from 4f0f464 to 107b722 Compare July 25, 2015 19:21
lanej added a commit that referenced this pull request Jul 25, 2015
retrieve token from api with username and password
@lanej lanej merged commit 274f501 into master Jul 25, 2015
@lanej lanej deleted the token-login branch July 25, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants