Patch for Issue #301 #302
Patch for Issue #301 #302
Conversation
| command "cd /data && tar zxf redis-#{redis_version}.tar.gz && sync" | ||
| not_if { FileTest.directory?("/data/#{redis_source_directory}") } | ||
| execute "unarchive Redis installer" do | ||
| command "cd /opt && tar zxf redis-#{redis_version}.tar.gz && sync" |
There was a problem hiding this comment.
In Chef it's generally better to use the cwd '/opt/my/dir then to do a cd /opt/my/dir && cmd
execute "unarchive Redis installer" do
cwd "/opt"
command "tar zxf redis-#{redis_version}.tar.gz && sync"
...
end
| end | ||
|
|
||
| execute "run redis-source/make install" do | ||
| command "cd /data/redis-source && make install" | ||
| command "cd #{redis_installer_directory} && make install" |
There was a problem hiding this comment.
same as previous comment in terms of using cwd vs cd /some/where && cmd
There was a problem hiding this comment.
Thanks for the feedback! I've updated the branch.
|
Just a general thought but this will never install again as long as you just have that redis_source_directory. Won't that lead to false positives on the not_ifs if you ever delete the redis source or that dir. Wouldn't it be better to test for another file in the system like the redis-server binaries? |
|
Completely agree on the concern for false positives. I just have to keep this PR short and sweet, that might have to be addressed in another PR. |
|
Thanks @AlexMorreale, have opened #303 for further addressing the false positives. |
|
Awesome!!! Happy to help/contribute. |
Download Redis installer in /opt.
#301