Fixed callback never called for bgapi #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases the command replies before attaching the event listener for the reply. Is there a particular reason for which the jobid is taken from the event header given that in all cases it is available?
|
👍 Good change, thanks for catching this. |
englercj
added a commit
that referenced
this pull request
Jul 7, 2015
Fixed callback never called for bgapi
|
Can you release it? |
|
@englercj Thank you for the release! Thank you for your reactivity! Thank you for developing this great library :) |
|
You're welcome! Let me know if there is anything else I can do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the command replies before attaching the event listener for the reply. When this happens the callback is never called.
Is there a particular reason for which the jobid is taken from the event header given that in all cases it is available?