Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure bgapi can invoke callback even if not jobid parameter #47

Merged
merged 2 commits into from
Jul 19, 2015
Merged

make sure bgapi can invoke callback even if not jobid parameter #47

merged 2 commits into from
Jul 19, 2015

Conversation

pandeng
Copy link
Contributor

@pandeng pandeng commented Jul 19, 2015

No description provided.

@englercj
Copy link
Owner

Cool, I would also remove the if(jobid) check in the sendApiCommand function since now it is guaranteed to be defined.

Also, looks like this is to fix #46?

@pandeng
Copy link
Contributor Author

pandeng commented Jul 19, 2015

Great, i agree that

englercj added a commit that referenced this pull request Jul 19, 2015
@englercj
Merge pull request #47 from pandeng/master
703cf32 
make sure bgapi can invoke callback even if not jobid parameter
@englercj englercj merged commit 703cf32 into englercj:master Jul 19, 2015
@englercj englercj mentioned this pull request Jul 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pandeng @englercj