Fix Connection.execute not to leak, add test for this #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the modifications to the execute callback handling does not accidentally trigger other events. Sends a different event before the actual response to ensure that englercj#23 will not occur again.
A session is identified by the variable 'uuid'. Multiple command requests/responses are possible, hence the callback was registered only once before. These were however not cleaned up. Take a different approach, always register an event handler for the session and check in the callback whether the response matched the request. This results in a number of calls that grows linearly to the number of open requests, but this number is usually small anyway. Fixes englercj#54
Lekensteyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test that detects the issue from #23 and adds an alternative fix that avoids the callback leak in #54.