-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for @property on classes (including tests) #91
support for @property on classes (including tests) #91
Conversation
…into feature/class-properties-with-tests
Thanks @aidinabedi for adding tests. Glad you did, because it looks like They both contain:
|
It's not the job of
|
@englercj I've added additional duplicates to illustrate that the behavior is the same, whether you use |
Fair enough. |
Thanks for providing the tests @aidinabedi. Couldn't find the time myself. |
@HackbrettXXX No problem! |
We need support for class properties and since #73 has not been updated since May. I decided to take it upon myself to fulfill the requirement regarding tests, as stated in #73 (comment).
So this PR is based on the work done by @HackbrettXXX, with the addition of test cases. See output: https://travis-ci.org/englercj/tsd-jsdoc/builds/575963771#L251