Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft-05: Group Order missing from SUBSCRIBE_OK #12

Closed
englishm opened this issue Oct 31, 2024 · 2 comments
Closed

draft-05: Group Order missing from SUBSCRIBE_OK #12

englishm opened this issue Oct 31, 2024 · 2 comments

Comments

@englishm
Copy link
Owner

Found while testing draft-05 interop with @lminiero.

SUBSCRIBE_OK
{
  Subscribe ID (i),
  Expires (i),
  Group Order (8),
  ContentExists (f),
  [Largest Group ID (i)],
  [Largest Object ID (i)]
}

draft-ietf-moq-transport-05 §6.12

fn encode<W: bytes::BufMut>(&self, w: &mut W) -> Result<(), EncodeError> {
self.id.encode(w)?;
self.expires.unwrap_or(0).encode(w)?;
Self::encode_remaining(w, 1)?;
match self.latest {
Some((group, object)) => {
w.put_u8(1);
group.encode(w)?;
object.encode(w)?;
}
None => {
w.put_u8(0);
}
}
Ok(())
}

Since we haven't landed draft-06 changes yet (#8) we can fix this in main and also update the draft-ietf-moq-transport-05 branch.

@englishm
Copy link
Owner Author

In b4ad512 I missed SUBSCRIBE_OK.

englishm added a commit that referenced this issue Oct 31, 2024
Just parsing/encoding for now.
Still punting on making this change the actual delivery order.

Addresses #12
@englishm
Copy link
Owner Author

englishm commented Nov 1, 2024

Fixed in #13

@englishm englishm closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant