moq-transport draft-05 initial wire format updates #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
englishm
force-pushed
the
draft-ietf-moq-transport-05
branch
from
be6ac23 to
23dfe08
Compare
draft-05 wire format update Don't do anything with it, but make sure we can encode/decode Subscribe and SubscribeUpdate messages, at least
draft-05 wire format update Don't do anything with it yet, but at least make sure we can parse correctly it in Subscribe and SubscribeUpdate messages
Replace send order with publisher priority and update size to u8 as per draft-05 Don't change anything else about how this is used yet though, only update wire format parsing and related types.
englishm
force-pushed
the
draft-ietf-moq-transport-05
branch
from
23dfe08 to
1f9a06e
Compare
We no longer have sufficient granularity to support ms-precision timestamps, so default to equal priority for all groups for now.
publisher priority in draft-05 has a more limited granularity than send order did and we can no longer map group ids into this domain without rolling over. For now just use a default priority of 127.
Also, still need to sort out crate names with @kixelated so we can actually push releases to crates.io... Mainly interested in moq-pub, moq-sub, moq-relay, and moq-clock.
englishm
changed the title
englishm
pushed a commit
that referenced
this pull request
Oct 25, 2024
Renaming the bins invoked in relay and clock dev scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal updates for draft-05. Not intended to be comprehensive, just breaking up changes towards draft-07 incrementally.
Intentionally skipping actually doing anything with priorities here because there are still identified ambiguities ( moq-wg/moq-transport#512 , moq-wg/moq-transport#517 , moq-wg/moq-transport#585 ) in the draft-05 text
draft-04 to draft-05 diff: