actually disable grpc when no grpc & fixes grpc issues on linux #101
Conversation
CMakeLists.txt
Outdated
| option(RGM_ENABLE_GRPC_SERVER "Enable the GRPC client plugin for compilation and code analysis." ON) | ||
| else() | ||
| option(RGM_ENABLE_GRPC_SERVER "Enable the GRPC client plugin for compilation and code analysis." OFF) | ||
| endif() |
There was a problem hiding this comment.
Why did you do this? That was super clean. And also why not:
if (WIN32)
set(RGM_ENABLE_GRPC_SERVER_ON ON)
else()
set(RGM_ENABLE_GRPC_SERVER_ON OFF)
endif()
option(RGM_ENABLE_GRPC_SERVER "Enable the GRPC client plugin for compilation and code analysis." ${RGM_ENABLE_GRPC_SERVER_ON})There was a problem hiding this comment.
cause your way completely hides the option on linux mine just disables it
There was a problem hiding this comment.
also, cause i dont have OCD like u
There was a problem hiding this comment.
Well it's not really OCD, it's just like if you have to type that string multiple times you are more likely to make a typo and cause a run time bug. Whereas if you make a typo in my way, even though it's more characters, it's instead more likely to be a compile time error.
There was a problem hiding this comment.
sounds like ocd to me. if you tested that works ill append the pr tho
| #include "Plugins/ServerPlugin.h" | ||
| #endif |
There was a problem hiding this comment.
Thanks, I did miss that one.
fundies
changed the title
partner of enigma-dev/enigma-dev#1919