Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VCPKG #128

Closed
wants to merge 1 commit into from
Closed

Update VCPKG #128

wants to merge 1 commit into from

Conversation

RobertBColton
Copy link
Contributor

@RobertBColton RobertBColton commented Jun 18, 2020

This is supposed to include a fix for the MSVC build's icu vcpkg issue.

@fundies
Copy link
Contributor

fundies commented Jun 18, 2020

Looks like google's hack broke this build too. Can you try commenting this line: https://github.com/enigma-dev/RadialGM/blob/master/CMakeLists.txt#L11 and see if that helps any?

@RobertBColton RobertBColton deleted the vcpkg-icu-update branch June 18, 2020 13:05
@RobertBColton
Copy link
Contributor Author

I recreated it as #129 so that it has the DLLEXPORT fixes we just merged.

@RobertBColton
Copy link
Contributor Author

It's also not going to work until #130 is merged.

@RobertBColton
Copy link
Contributor Author

Alright with #130 merged, I created #131 that has the Arch fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants