Script/Shader Editor Window Icon #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason these two didn't have their own window icons already is because they are reusing the same
CodeEditor.uiform, which is totally acceptable. The alternative would be for us to create separateShaderEditor.uiandScriptEditor.uiforms that both embed theCodeEditor.uilike it's a custom widget. I have no particular preference myself.I should mention that this relates to #137 keybinding preferences. In GMS2 the keybinding preferences are the same for the script and shader editors, likely because YoYo is doing a similar kind of abstraction internally for the editor they built.
https://docs2.yoyogames.com/source/_build/1_overview/2_quick_start/8_shortcuts.html