Sprite Collision Mask Tweak #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBColton
force-pushed
the
sprite-mask-tweak
branch
from
88c037b to
b1e3cb8
Compare
RobertBColton
force-pushed
the
sprite-mask-tweak
branch
from
b1e3cb8 to
cbc34cd
Compare
JoshDreamland
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am iterating on our earlier change of the sprite collision mask radio buttons to combo boxes. It seems GMS2 has gone the same direction but additionally combined the shape and bbox mode under the same group, which I am proposing here. I fixed a typo with the mapping to the shape combo box which was mapping the group before. I also decided to add the missing alpha tolerance slider while I was in here which will later need added to the automatic bbox computation.